Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seg fault processing a Deployment #9

Closed
viniciusmucuge opened this issue Oct 20, 2021 · 3 comments · Fixed by #10
Closed

Seg fault processing a Deployment #9

viniciusmucuge opened this issue Oct 20, 2021 · 3 comments · Fixed by #10
Assignees
Labels
bug Something isn't working

Comments

@viniciusmucuge
Copy link

viniciusmucuge commented Oct 20, 2021

Trying to helmify some manifests I have the following segmentation fault code:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1691f93]

goroutine 1 [running]:
github.com/arttor/helmify/pkg/processor/deployment.deployment.Process({}, {0x1906678, 0xc0000aed40}, 0xc00000e548)
	/home/runner/work/helmify/helmify/pkg/processor/deployment/deployment.go:71 +0x293
github.com/arttor/helmify/pkg/app.(*appContext).process(0xc0000e9d50, 0xc00000e548)
	/home/runner/work/helmify/helmify/pkg/app/context.go:75 +0x39c
github.com/arttor/helmify/pkg/app.(*appContext).CreateHelm(0xc0000e9d50, 0xc000308000)
	/home/runner/work/helmify/helmify/pkg/app/context.go:57 +0x252
github.com/arttor/helmify/pkg/app.Start({0x18f4d20, 0xc00000e010}, {{0x7ffeefbffa88, 0xc}, {0x17ee766, 0x1}, 0x0, 0x0})
	/home/runner/work/helmify/helmify/pkg/app/app.go:58 +0x737
main.main()
	/home/runner/work/helmify/helmify/cmd/helmify/main.go:21 +0x1b1

Someone had a similar situation?

@arttor arttor self-assigned this Oct 20, 2021
@arttor arttor added the bug Something isn't working label Oct 20, 2021
@arttor
Copy link
Owner

arttor commented Oct 20, 2021

@viniciusmucuge i found the problem. There is no check if deployment spec.replicas is missing. I will create a fix and release. As a workaround, you can set some value to spec.replicas in deployment.yaml.

@arttor
Copy link
Owner

arttor commented Oct 20, 2021

@viniciusmucuge fixed in v0.3.3 release

@viniciusmucuge
Copy link
Author

Thanks a lot @arttor
After upgrading to v0.3.3, worked correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants