Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with exec (sync) on 0.12/io.js #197

Closed
dominykas opened this issue Mar 24, 2015 · 4 comments
Closed

Problems with exec (sync) on 0.12/io.js #197

dominykas opened this issue Mar 24, 2015 · 4 comments
Labels

Comments

@dominykas
Copy link

When the process being exec'ed errors out and outputs a lot of text, shelljs errors out on node 0.12/io.js (i.e. when support for actual execSync is present) on Travis (I'm not able to reproduce this on my Mac).

See this gist: https://gist.github.com/dominykas/f67e139a93fffdeb4c11

See output-mac.txt for the expected case (i.e. git command errors out, dumps quite some text) and see output-travis.txt for the error (Travis build from source)

@dominykas
Copy link
Author

Updated the top post with a reduced test case - it seems that if there's an error, the output stream is getting closed too soon on nodes with support for execSync.

@dominykas dominykas changed the title Problems with exec (sync) Problems with exec (sync) on 0.12/io.js Mar 31, 2015
@ariporad
Copy link
Contributor

@dominykas: Sorry this issue is so old! Would you mind re-doing this with the latest version of shelljs and letting me know if it is still broken? Thanks!

@ariporad ariporad added blocked high priority Linux Linux-specific issues labels Jan 24, 2016
dominykas added a commit to dominykas/shelljs-issue-197 that referenced this issue Jan 24, 2016
@dominykas
Copy link
Author

I created this repo: https://github.com/dominykas/shelljs-issue-197

With results here:

So I guess it's fine, as long as you know what you fixed? :)

@nfischer
Copy link
Member

Perhaps the issue was related to #206 (which was fixed by #214)? Both @ariporad and I came on after v0.5.3, so I'm not as familiar with the issues back then. Reading your error messages however, it looks like it's related. Closing for now, but please reopen if the issue ever returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants