Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): add desktopBackground prop to all themes #238

Merged
merged 6 commits into from
Jan 15, 2022

Conversation

tpenguinltg
Copy link
Contributor

This PR partially implements #223. This adds the desktopBackground prop to all my themes and also maps Background to desktopBackground in the Windows theme adapter.

My themes are the low-hanging fruit since the colours are readily available and need little transformation. The themes based on the default Windows themes are next (eventually).

@vercel
Copy link

vercel bot commented May 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arturbien/react95/3J6RQUPMm2EKaqV8cmuvUr8jEMiu
✅ Preview: https://react95-git-fork-tpenguinltg-feat-tpenguinltg-desktop-arturbien.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9522192:

Sandbox Source
React95 template Configuration

@arturbien
Copy link
Member

arturbien commented May 18, 2021

@tpenguinltg Thanks for submitting this PR! <3
I think we should add this desktopBackground prop to every theme in one go.
I think for now we can just add a teal color (rgb(84, 170, 170)) to every other theme that's not yours. Can you do that in this PR? 🙌

@tpenguinltg
Copy link
Contributor Author

@arturbien Many apologies, I thought I had updated this months ago. I added the proper desktop colours for the stock Windows themes and teal for everything else. I also made components like Window use the new theme prop so that it's easy to see the new changes.

@tpenguinltg tpenguinltg changed the title feat(themes): add desktopBackground prop to all themes by tPenguinLTG feat(themes): add desktopBackground prop to all themes Jan 11, 2022
@arturbien arturbien merged commit dec09cf into react95-io:master Jan 15, 2022
@arturbien
Copy link
Member

🎉 This PR is included in version 3.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arturbien
Copy link
Member

@tpenguinltg great job. backgrounds looking great 🤓 merged and deployed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants