-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(themes): add desktopBackground prop to all themes #238
feat(themes): add desktopBackground prop to all themes #238
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/arturbien/react95/3J6RQUPMm2EKaqV8cmuvUr8jEMiu |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9522192:
|
@tpenguinltg Thanks for submitting this PR! <3 |
Use colors from original Windows theme.
Use placeholder #008080 (teal) until more background colours are designed.
Create a styled Wrapper component that consumes the theme and uses the desktopBackground prop.
f8345ad
to
9522192
Compare
@arturbien Many apologies, I thought I had updated this months ago. I added the proper desktop colours for the stock Windows themes and teal for everything else. I also made components like |
🎉 This PR is included in version 3.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@tpenguinltg great job. backgrounds looking great 🤓 merged and deployed! |
This PR partially implements #223. This adds the
desktopBackground
prop to all my themes and also mapsBackground
todesktopBackground
in the Windows theme adapter.My themes are the low-hanging fruit since the colours are readily available and need little transformation. The themes based on the default Windows themes are next (eventually).