Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(themes): exported src/common/utils to dist/utils for peggysPastels, fixed RGB colors in aiee #250

Closed
wants to merge 2 commits into from

Conversation

elanora96
Copy link

Fixes #231

(This is my first time seeing rollup so please excuse me if this was not the right way to fix it 😉)

@vercel
Copy link

vercel bot commented Aug 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arturbien/react95/7S7rVpnP5uxdqfF8jWj16XERbgD5
✅ Preview: https://react95-git-fork-burk96-master-arturbien.vercel.app

@arturbien
Copy link
Member

Hey @burk96 ! Sorry for late response. And thanks for contributing <3
Actually I have a different plan on fixing the missing util issue. I'll simply convert all themes that use mapFromWindowsTheme util to the React95 format (see the default theme). I am currently working on React Native version of the library and I already did that there, so I'll just port it to the web version.

But we still need to fix the AIEE theme. Can you open up a new pull request with just the fix for the AIEE theme? Also we're using standaridzed commit messages (see https://www.conventionalcommits.org/) to automate versioning. Please put something like "fix: aiee theme colors" as a commit message, or run git cz to use commiting CLI.

Thanks again and welcome to React95 ❤️

@twopills
Copy link

Hey @burk96 ! Sorry for late response. And thanks for contributing <3 Actually I have a different plan on fixing the missing util issue. I'll simply convert all themes that use mapFromWindowsTheme util to the React95 format (see the default theme). I am currently working on React Native version of the library and I already did that there, so I'll just port it to the web version.

But we still need to fix the AIEE theme. Can you open up a new pull request with just the fix for the AIEE theme? Also we're using standaridzed commit messages (see https://www.conventionalcommits.org/) to automate versioning. Please put something like "fix: aiee theme colors" as a commit message, or run git cz to use commiting CLI.

Thanks again and welcome to React95 heart

Hi @arturbien there are news for this issue? Thanks

@WesSouza
Copy link
Member

WesSouza commented Aug 5, 2022

We have fixed this on #289 and it is part of v3.12.2.

@WesSouza WesSouza closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with peggysPastels theme
4 participants