ExceptionRaisedInUnexpectedLocation in constructer

[melashkov]

Hi, I have found another issue, I am rising en exception when class being constructed
example:

class FooBar(isValid: Boolean) {

    init {
        if (!isValid) {
            throw IllegalArgumentException()
        }
    }
}

The detekt tells me "This method is not expected to throw exceptions. This can cause weird behavior.", is that expected that you should not rise exceptions in init?

[arturbosch]

This is a good question. Init is often used to validate state in Kotlin. Should we remove this case/make it optional @Mauin @schalkms ?

[schalkms]

I think an exception thrown in an init block is ok. I wouldn’t call it a bug. I’ll take a look at it tomorrow.

[arturbosch]

Yeah. how about a new label false-positive? So make init optionally detected or just remove this case?

[schalkms]

Sounds good to me!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.