Handle @Suppress("UNCHECKED_CAST") for UnsafeCast rule

[xgouchet]

IntelliJ / Android Studio detect when a cast is unsafe and show a warning, which can be disabled using the @Suppress("UNCHECKED_CAST") annotation. It seems redundant to also add the UnsafeCast rule, ending with some code annotated with @Suppress("UNCHECKED_CAST", "UnsafeCast")

[Mauin]

If the IntelliJ warning is enough for you, disabling the rule in your detekt configuration sounds like a good idea.

[xgouchet]

Unfortunately that doesn't do it for me. IntelliJ mostly gives a warning when generics are involved, from what I gathered. The following code won't trigger any warning in IntelliJ, but are detected by the UnsafeCast rule :

val foo = something as AnotherThing

[Mauin]

Ah, I see. So its more about making sure the detekt rules also match the suppression rules of IntelliJ. We could add a List to each rule that can take in the names of "similar" rules in other static analysis suites. That way we could make this possible that only one @Suppress annotation will also suppress the detekt rule.

[xgouchet]

Yep that'd be great !

[Mauin]

I can take a look at implementing something that will make that work. WDYT @arturbosch @schalkms does something like this make sense?

[schalkms]

I makes sense. I think detekt has some rules where this mechanism can be applied. This means that this should be a generic functionality if possible.
Thanks for bringing this up @xgouchet

[Mauin]

Yeah. I'll look into it later today/tomorrow

…

On Tue, Feb 6, 2018, 16:17 schalkms ***@***.***> wrote: I makes sense. I think detekt has some rules where this mechanism can be applied. This means that this should be a *generic* functionality if possible. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#726 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF4k0UrXxSyVnobU-wMfr3xNT4cZ6jR3ks5tSGzsgaJpZM4R7FGY> .

[arturbosch]

Yep, surprisingly I thought about the same thing yesterday 👍 for this

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.