Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmptyCatchBlock.allowedExceptionNameRegex doesn't seem to be useful #779

Closed
Mygod opened this issue Mar 8, 2018 · 4 comments
Closed

EmptyCatchBlock.allowedExceptionNameRegex doesn't seem to be useful #779

Mygod opened this issue Mar 8, 2018 · 4 comments
Labels
Milestone

Comments

@Mygod
Copy link
Contributor

Mygod commented Mar 8, 2018

Running: f59aa94 (CLI)
Reported on:
https://github.com/Mygod/VPNHotspot/blob/d2e9ff226c4d7ea453c7dcd3bea5da8c76065894/mobile/src/main/java/be/mygod/vpnhotspot/net/IpNeighbourMonitor.kt#L58

Config:

  EmptyCatchBlock:
    active: true
    allowedExceptionNameRegex: "^(ignore|expected).*"
@schalkms
Copy link
Member

schalkms commented Mar 8, 2018

I think this regex config is not included in RC6-3.
I also can't reproduce it with the latest status from the repo.
Either way, I just included this test-case in a new PR.

@Mygod
Copy link
Contributor Author

Mygod commented Mar 8, 2018

I will assume it's working then since I can't run the latest commit. Thanks!

@Mygod Mygod closed this as completed Mar 8, 2018
@Mygod
Copy link
Contributor Author

Mygod commented Mar 9, 2018

I disabled UnusedPrivateMember and indeed it's my bad.

@arturbosch arturbosch added this to the RC6-4 milestone Mar 15, 2018
@lock
Copy link

lock bot commented Jun 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants