Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kotlin 1.3.0 #1296

Merged
merged 2 commits into from Nov 2, 2018
Merged

Upgrade to Kotlin 1.3.0 #1296

merged 2 commits into from Nov 2, 2018

Conversation

3flex
Copy link
Member

@3flex 3flex commented Oct 30, 2018

No description provided.

Contracts in Kotlin stdlib 1.3 make this assertion after a `require(... != null)` unnecessary.
@3flex
Copy link
Member Author

3flex commented Oct 30, 2018

If #1298 is merged first, hold off on merging this - it will be possible to update the Gradle plugin's Kotlin version to 1.3.0 at the same time, so will update this PR to do that after kotlin-dsl is dropped from the Gradle plugin.

Copy link
Collaborator

@Mauin Mauin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@arturbosch
Copy link
Member

KK, #1298 is merged :)

@arturbosch arturbosch merged commit ca67824 into detekt:master Nov 2, 2018
@arturbosch arturbosch added this to the RC10 milestone Nov 2, 2018
@3flex 3flex deleted the patch-4 branch November 3, 2018 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants