Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kotlin to 1.3.20 #1438

Merged
merged 3 commits into from Feb 5, 2019
Merged

Update Kotlin to 1.3.20 #1438

merged 3 commits into from Feb 5, 2019

Conversation

schalkms
Copy link
Member

No description provided.

@schalkms
Copy link
Member Author

Looks like a KtLint problem
I tag it as blocked.

io.gitlab.arturbosch.detekt.formatting.KtLintIntegrationSpec > it should work like KtLint FAILED
    java.lang.NoSuchFieldError: LONG_STRING_TEMPLATE_ENTRY
        at com.github.shyiko.ktlint.ruleset.standard.StringTemplateRule.visit(StringTemplateRule.kt:29)
        at io.gitlab.arturbosch.detekt.formatting.FormattingRule.apply(FormattingRule.kt:64)
        at io.gitlab.arturbosch.detekt.formatting.KtLintMultiRule$visit$2$$special$$inlined$forEach$lambda$1.invoke(KtLintMultiRule.kt:84)
        at io.gitlab.arturbosch.detekt.formatting.KtLintMultiRule$visit$2$$special$$inlined$forEach$lambda$1.invoke(KtLintMultiRule.kt:44)
        at io.gitlab.arturbosch.detekt.api.MultiRule.runIfActive(MultiRule.kt:27)
        at io.gitlab.arturbosch.detekt.formatting.KtLintMultiRule$visit$2.invoke(KtLintMultiRule.kt:84)
        at io.gitlab.arturbosch.detekt.formatting.KtLintMultiRule$visit$2.invoke(KtLintMultiRule.kt:44)
        at io.gitlab.arturbosch.detekt.formatting.KtLintMultiRule.visitTokens(KtLintMultiRule.kt:96)
        at io.gitlab.arturbosch.detekt.formatting.KtLintMultiRule.visit(KtLintMultiRule.kt:82)
        at io.gitlab.arturbosch.detekt.api.BaseRule.visitFile(BaseRule.kt:36)
        at io.gitlab.arturbosch.detekt.api.RuleSet.accept(RuleSet.kt:23)
        at io.gitlab.arturbosch.detekt.formatting.KtLintIntegrationSpec$1$1$1.invoke(KtLintIntegrationSpec.kt:23)
        at io.gitlab.arturbosch.detekt.formatting.KtLintIntegrationSpec$1$1$1.invoke(KtLintIntegrationSpec.kt:13)

@vanniktech
Copy link
Contributor

Yeah there's an open issue on their repo.

Yet another reason to ditch ktlint here.

@vanniktech
Copy link
Contributor

pinterest/ktlint#321

@schalkms
Copy link
Member Author

Thanks for the reference.

@codecov-io
Copy link

codecov-io commented Feb 4, 2019

Codecov Report

Merging #1438 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1438   +/-   ##
=========================================
  Coverage     74.62%   74.62%           
  Complexity     1716     1716           
=========================================
  Files           326      326           
  Lines          5171     5171           
  Branches        934      935    +1     
=========================================
  Hits           3859     3859           
  Misses          788      788           
  Partials        524      524
Impacted Files Coverage Δ Complexity Δ
...turbosch/detekt/rules/style/UnusedPrivateMember.kt 93.47% <0%> (ø) 5% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e4bad5...e0b9980. Read the comment docs.

@schalkms schalkms removed the blocked label Feb 4, 2019
@arturbosch arturbosch merged commit 4315c6c into detekt:master Feb 5, 2019
@arturbosch arturbosch added this to the 1.0.0 milestone Feb 5, 2019
@schalkms schalkms deleted the kotlin-v1.3.20 branch February 7, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants