Refactoring: use more readable functions #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1916 +/- ##
========================================
Coverage 80.4% 80.4%
+ Complexity 1974 1973 -1
========================================
Files 326 326
Lines 5517 5517
Branches 1027 1027
========================================
Hits 4436 4436
Misses 543 543
Partials 538 538
Continue to review full report at Codecov.
|
3flex
approved these changes
Sep 13, 2019
arturbosch
reviewed
Sep 14, 2019
| @@ -21,7 +21,7 @@ class KotlinEnvironmentUtilsTest : Spek({ | |||
| .toList() | |||
|
|
|||
| val languageVersion = classpathFiles.getKotlinLanguageVersion() | |||
| assertThat(languageVersion).isNotNull() | |||
| assertThat(languageVersion).isNotNull | |||
There was a problem hiding this comment.
Interesting, on which IntelliJ version are you and is the new kotlin type inference enabled in kontlinc by default in 1.3.50? Last time I removed braces for assertJ "getters" I got compiler errors in IDEA.
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.