Simplify UnnecessaryApplySpec test cases #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
schalkms
commented
Mar 18, 2020
schalkms
commented
- Fixes invalid Kotlin code in test snippets
- Use compileAndLint() instead of lint()
* Fixes invalid Kotlin code in test snippets * Use compileAndLint() instead of lint()
* Uses safe-cast expression * Doesn't use unsupported inline classes
Codecov Report
@@ Coverage Diff @@
## master #2448 +/- ##
=========================================
Coverage 82.94% 82.94%
Complexity 2178 2178
=========================================
Files 359 359
Lines 6226 6226
Branches 1143 1143
=========================================
Hits 5164 5164
Misses 480 480
Partials 582 582Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Mar 18, 2020
detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryApplySpec.kt
Outdated
Show resolved
Hide resolved
detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryApplySpec.kt
Outdated
Show resolved
Hide resolved
Co-Authored-By: Brais Gabín <braisgabin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.