Added UnnecessaryConversionTemporary rule #279
Conversation
| private val types: Set<String> = hashSetOf("Boolean", "Byte", "Short", "Integer", "Long", "Float", "Double") | ||
|
|
||
| override fun visitCallExpression(expression: KtCallExpression) { | ||
| if (types.contains(expression.calleeExpression?.text) && expression.nextSibling?.nextSibling?.text == "toString()") { |
There was a problem hiding this comment.
Please extract both conditons to functions with a meaningful name.
| override val issue: Issue = Issue("UnnecessaryConversionTemporary", Severity.Performance, | ||
| "Avoid temporary objects when converting primitive types to String") | ||
|
|
||
| private val types: Set<String> = hashSetOf("Boolean", "Byte", "Short", "Integer", "Long", "Float", "Double") |
There was a problem hiding this comment.
Because he uses types.contains later which is O(1). setOf is a LinkedSet O(n) ?
There was a problem hiding this comment.
I thought it was a HashSet by default, my bad 👍
| import org.assertj.core.api.Assertions | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| class UnnecessaryConversionTemporaryTest { |
There was a problem hiding this comment.
I thought the rest of the project used Spek?
| import io.gitlab.arturbosch.detekt.api.Severity | ||
| import org.jetbrains.kotlin.psi.KtCallExpression | ||
|
|
||
| class UnnecessaryConversionTemporary(config: Config = Config.empty) : Rule(config) { |
There was a problem hiding this comment.
What about UnnecessaryTemporaryInstantiation? "conversion temporary" doesn't seem very clear to me
|
Thanks for the code review. |
|
Spek is the preferred. Junit5 is still used because spek had some issues before 1.0 where I started using it |
|
@arturbosch ok |
|
Looks good, will be added to RC2 soon 👍 |
No description provided.