Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Kotlin 1.1.60 #546

Merged
merged 1 commit into from Nov 16, 2017
Merged

Update to Kotlin 1.1.60 #546

merged 1 commit into from Nov 16, 2017

Conversation

3flex
Copy link
Member

@3flex 3flex commented Nov 14, 2017

This stood out:

KT-20462 Don't create an array copy for '*(...)'

Does that mean SpreadOperator check isn't required anymore? detekt's description says "Using a spread operator causes a full copy of the array to be created before calling a method has a very high performance penalty."

Seems KT-20462 fixes exactly that performance problem, so the detekt rule is redundant?

@Mauin
Copy link
Collaborator

Mauin commented Nov 14, 2017

The benchmarks that led to the creation of the SpreadOperator rule are available here: https://github.com/renatoathaydes/kotlin-hidden-costs-benchmark

We can re-run the benchmarks with the new Kotlin version to verify that the performance is now better. This should be handled as part of a different Issue/PR, though.

@3flex
Copy link
Member Author

3flex commented Nov 15, 2017

I ran the benchmark, strangely I don't see any difference between running with Kotlin 1.1.3 and Kotlin 1.1.60. Probably made some mistake while I ran the benchmarks, or I'm not understanding the release notes. So I won't open a new PR/issue for any SpreadOperator changes.

@arturbosch
Copy link
Member

arturbosch commented Nov 16, 2017

Oh, I did not read your last comment ... I opened an issue .. for the future! As I read KT-20462 so that only using a newly created array with constants should not trigger a new array by the compiler not that having an array passed to a function and just using the spread operator on it. Thanks for the PR!

@3flex 3flex deleted the patch-3 branch November 16, 2017 11:01
@arturbosch arturbosch added this to the RC5-5 milestone Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants