Add trailing whitespace rule #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misaelmt
force-pushed
the
feat/no-railing-whitespaces
branch
5 times, most recently
from
51e3918
to
082c4c2
Compare
vanniktech
approved these changes
Mar 9, 2018
|
What should I do to add this feature to auto correction? It would be nice to add it in a follow up PR. |
|
I proposed auto correction here but it didn't get approved. I'm just nagging on each rule that would benefit from it in hope that we'll get auto correcting. |
|
As @vanniktech mentioned atm detekt does not have rules with auto correction. |
misaelmt
force-pushed
the
feat/no-railing-whitespaces
branch
from
082c4c2
to
3a98bde
Compare
arturbosch
reviewed
Mar 10, 2018
| Debt.FIVE_MINS) | ||
|
|
||
| override fun visitKtFile(file: KtFile) { | ||
| val lines = file.text.splitToSequence("\n") |
There was a problem hiding this comment.
This should be added to the FileParsingRule.
arturbosch
requested changes
Mar 10, 2018
misaelmt
force-pushed
the
feat/no-railing-whitespaces
branch
from
3a98bde
to
72f9aca
Compare
|
@arturbosch I addressed your comments. Please re-review at your convenience. |
arturbosch
approved these changes
Mar 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't add <compliant> and <noncompliant> blocks to the KDoc because it's really easy to understand what the rule does and it's hard to see those white spaces at the end of the lines in the KDoc comments.