Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't Ask for Authorization #23

Closed
johnnyshankman opened this issue Nov 23, 2015 · 5 comments
Closed

Doesn't Ask for Authorization #23

johnnyshankman opened this issue Nov 23, 2015 · 5 comments

Comments

@johnnyshankman
Copy link

At no point is there a call for requestWhenInUseAuthorization or requestAlwaysAuthorization for ios8 and ios9 support. I think this should either be asked upon startDetection and/or should be exposed to the developer to call whenever they see fit so that they can ask for it at the right time in their UX.

Either way this issue makes it really weird to get Core Location updates because we either have to edit your Pod or ask for it manually on an unused Location Manager instance.

@johnnyshankman
Copy link
Author

This might be related to the fact that the readme tells me to download the wrong version of the repo?

I only say this because I see more code in my fork'd repo than I do in my pod installed version.

@johnnyshankman
Copy link
Author

Yeah can confirm that installing using Pods causes me to get a weird package. I don't have StepDetector or block support?

@arturdev
Copy link
Owner

Yes, it should be better if you download repo directly.
I haven't updated pods yet.

@johnnyshankman
Copy link
Author

@arturdev that makes sense thank you.

@johnnyshankman
Copy link
Author

I think i'm going to open a separate issue for not being able to set backgroundLocation updates in iOS9 because we need to be able to set the CLLocationManager's property allowsBackgroundLocationUpdates to true.

https://developer.apple.com/library/prerelease/ios/documentation/CoreLocation/Reference/CLLocationManager_Class/index.html#//apple_ref/occ/instp/CLLocationManager/allowsBackgroundLocationUpdates

https://developer.apple.com/library/prerelease/ios/releasenotes/General/iOS90APIDiffs/Objective-C/CoreLocation.html

I've made my own version that does this currently, it was a real easy update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants