Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements: Custom Cell Rendering/Retention Charts #10

Closed
gryevns opened this issue Sep 17, 2018 · 1 comment
Closed

Enhancements: Custom Cell Rendering/Retention Charts #10

gryevns opened this issue Sep 17, 2018 · 1 comment

Comments

@gryevns
Copy link
Contributor

gryevns commented Sep 17, 2018

Hey, couple of suggestions/enhancements - want to know your thoughts before raising any PRs...

  1. Custom Cell Render

It would be ncie to render something other than   within cells, e.g. the value with unit.

<HeatMap render={value => `${value}%`} />
  1. Background Opacity

Currently setting the background & opacity means any textual value (e.g. above) inherits the opacity - instead it would be nice to use rgba - this means converting from hex to rgba to maintain backwards compatibility.

  1. Retention Chart Support

The current gradient implementation works on a min/max across the whole dataset, whereas, for a retention chart the first value of each row is the "base" and the subsequent row values have a gradient compared to this value.

<HeatMap type="retention" />

screen shot 2018-09-17 at 20 40 59

@arunghosh
Copy link
Owner

@gryevns The above 3 features looks good. I happy to have the pull request for these features. Thank you :)

@gryevns gryevns closed this as completed Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants