Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi server deployment is slower than mup 1.3.7 #958

Closed
WayneUong opened this issue Jun 11, 2018 · 5 comments
Closed

multi server deployment is slower than mup 1.3.7 #958

WayneUong opened this issue Jun 11, 2018 · 5 comments

Comments

@WayneUong
Copy link

I recently updated mup from 1.3.7 to the latest and I noticed that the meteor bundle is now dockerized on each server individually. With 1.3.7, the meteor docker image is built locally before being sent to each server. This makes deployment to multiple servers much slower. Is there a reason for doing this or my assumptions are wrong here?

@zodern
Copy link
Owner

zodern commented Jun 11, 2018

What docker image did you use with Mup 1.3.7?

@WayneUong
Copy link
Author

The abernix/meteord one. I tried your zodern/meteor-docker but it does feel a bit slower.

@zodern
Copy link
Owner

zodern commented Jun 12, 2018

Prepare Bundle started being enabled by default for zodern/meteor-docker in Mup 1.4, which could have made deployments slower. There shouldn't be a large difference between 1.3.7 and 1.4.5 when using abernix/meteord.

Starting in Mup 1.3, mup builds a docker image on the server during Prepare Bundle. It does slow down deploys, but makes them much more reliable and easier to troubleshoot. It also greatly speeds up starting the app. In mup 1.4.5, there is a new option app.docker.stopAppDuringPrepareBundle, which when set to false reduces the downtime to the amount of time it takes the app to start.

For Mup 1.5, I am looking into caching the app's npm dependencies, which will make deployments much faster when the dependencies haven't changed since the last deployment.

@x5engine
Copy link
Contributor

very nice @zodern but my app bundle is taking so much time! like 30 to 30 minutes wtf seriously?

@zodern zodern added this to Done in 1.5 Feb 25, 2020
@zodern
Copy link
Owner

zodern commented Feb 25, 2020

In Mup 1.5 there are two more optimizations:

  • When enabling the app.docker.useBuildKit option in the config, Prepare Bundle will be much faster
  • If you deploy to multiple servers, you can use a private docker registry. When it is enabled, uploading the bundle and running Prepare Bundle will only be done on one server instead of all of them.

If it is still too slow, you can disable Prepare Bundle with the app.docker.prepareBundle option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1.5
Done
Development

No branches or pull requests

3 participants