Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The accuracy of TSM-SELFY-R18/R50 on sth-sth v1 #1

Closed
whwu95 opened this issue Nov 6, 2021 · 4 comments
Closed

The accuracy of TSM-SELFY-R18/R50 on sth-sth v1 #1

whwu95 opened this issue Nov 6, 2021 · 4 comments

Comments

@whwu95
Copy link

whwu95 commented Nov 6, 2021

Hi, I have downloaded your official codes to reproduce the results of TSM-SELFY-R18 and R50 on the something-v1 dataset.
My top-1 accuracy of the R18 model is 42.6%, which is 48.4% in your paper.
And the top-1 accuracy of the R50 model is 48.3%, which is 52.5% in your paper.
Attached are my log files.
Did I get something wrong?
selfy-tsm50.log
selfy-tsm18.log

@whwu95
Copy link
Author

whwu95 commented Nov 6, 2021

To verify the effectiveness of the SELFY model, I also conduct the experiment on TSM-R18 and get the same results with SELFY-TSM counterpart. This SEFLY module does not seem to provide performance improvements.

So I check your codes and comparison with the official TSM codebases. I find you changed the data augmentation (e.g., selective Flip, resize images to 240x320). I just simply add these two augmentations to the original TSM, then get an unbelievable strong TSM baseline (+2% on sth-sthv1).

@arunos728
Copy link
Owner

Hello whwu95,
It seems that the result of your selfy-TSM18 is similar to the result of TSM18 in our paper (Table 4b), which means SELFY block does not work in your result.
I think that 'Spatial Correlation Sampler' does not work in your code, so could you try again after modifying line14 of selfy.py from 'use_corr_sampler=True' to 'use_corr_sampler=False'?
This is a modification about computing self-similarity without using 'Spatial Correlation Sampler'.

Thanks for your attention.
Please let me know if you need any help.

@whwu95
Copy link
Author

whwu95 commented Nov 29, 2021

Hello whwu95, It seems that the result of your selfy-TSM18 is similar to the result of TSM18 in our paper (Table 4b), which means SELFY block does not work in your result. I think that 'Spatial Correlation Sampler' does not work in your code, so could you try again after modifying line14 of selfy.py from 'use_corr_sampler=True' to 'use_corr_sampler=False'? This is a modification about computing self-similarity without using 'Spatial Correlation Sampler'.

Thanks for your attention. Please let me know if you need any help.

Yes, I have utilized the 'use_corr_sampler=False', but I get only 51.467% on sthv1, which is 52.5% on the paper.
Also, I got 63.45% on sthv2, which is 64.5% on the paper.
Attached is my log file. Did I get something wrong?
SELFY-R50-TSM-log.txt

@mm840511m
Copy link

Hi @whwu95,
According to the log files you provided, I encountered the same error message that you also had. How can I solve this error? Thank you.

FileNotFoundError: [Errno 2] No such file or directory: '/home/something-something-v2/frames/177891/img_00003.jpg'
FileNotFoundError: [Errno 2] No such file or directory: '/home/something-something-v2/frames/13376/img_00002.jpg'

Here's my log file :
log.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants