Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: e_header.php #1

Closed
LaocheXe opened this issue Nov 22, 2017 · 3 comments
Closed

Question: e_header.php #1

LaocheXe opened this issue Nov 22, 2017 · 3 comments

Comments

@LaocheXe
Copy link

Wouldn't be easier to add e_header.php and have it load the e107::js('core', "livestamp/moment.min.js"); and e107::js('core', "livestamp/livestamp.min.js"); so administrators don't have to add them in custom themes?

@arunshekher
Copy link
Owner

@LaocheXe,
Sorry I’m away on vacation now that why the delayed response. To answer your issue I think I assumed the way I used is the standard method to load third party libs, and on top of my head I don’t see why it would cause an issue with custom themes. Please correct me if I’m assuming things wrong.

@LaocheXe
Copy link
Author

LaocheXe commented Dec 9, 2017

Well I would need to add the two lines into my theme.php - when simply you could just add them into e_header.php in the plugin, which will enable the livestamp on the site without having to modify the theme. Because there is no inline editor for e107 to add into the theme in the admin area, and novice users who don't know how to edit php, this would be easier.

@arunshekher
Copy link
Owner

@LaocheXe You don’t need to add those JavaScript libs manually in a custom theme. They should be loaded automatically by e_footer.php just like e_header.php

I’m yet to shift fully into the coding mindset so I might still be overlooking something here, please accept my apologies if I’m not understanding you correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants