Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with some characters #15

Open
Jimmi08 opened this issue Mar 14, 2019 · 5 comments
Open

problem with some characters #15

Jimmi08 opened this issue Mar 14, 2019 · 5 comments

Comments

@Jimmi08
Copy link

Jimmi08 commented Mar 14, 2019

I see it is looking in display name

image

User setting:

image

so it works with á but not č

image

Limit is 15
image

@Jimmi08
Copy link
Author

Jimmi08 commented Mar 14, 2019

Next result:
if there is display name with those character, unique names are not correct, checked unique-mentions.txt

array (
  0 => '@Mi',
)

This same happens if Display name contains spaces.

@arunshekher
Copy link
Owner

@Jimmi08, Thank you & Sorry for the late response.

Yes the currently used RegEx pattern does not match those latin scripts with diacritic marks (accents) or non-latin characters at all.

I have improved the RegEx pattern in a development branch that adds support for these characters and they should be ready for release soon.

@Jimmi08
Copy link
Author

Jimmi08 commented Apr 22, 2019

Hi and thank you. I am not sure if I didn't write this somewhere else too but the problem is somewhere else.
The display name can have spaces too now. But normally there should be the same rules as for loginname (not real name - field names are really confusing here)

We solved this by setting display name = login name and this way members can't change it. I really can't remember now what fields are used by your plugin but now I found that there was a similar solution in old gold system plugin, I will check it when I find the time.

@arunshekher
Copy link
Owner

For all user matching this plugin only check for 'user_name' field in user table.

And fetches user_id, user_email, user_image, user_login fields for autocomplete popup and emailing.

We solved this by setting display name = login name and this way members can't change it.

By that did you mean its solved in the current development version of e107inc/e107 repo?

I firmly believe if it has problems finding latin characters with diacritic marks from 'user_name' table that's because its not implemented yet.

@Jimmi08
Copy link
Author

Jimmi08 commented Apr 24, 2019

Hi, no changes in core. This is how I understand this, I could be wrong.

User can have different user_name and display name. This is set in preferences and you can allow it only for some classes.
For example. my login name is Jimako but users can see me as Main Admin. They don't know my login name because it's not displayed, so they will search for the display name. By setting display name = login name in core prefs, they will see user name now and they will look (type) for Jimako. Do you know what I try to say? (or my user name is totally different to have it safe and they see only Jimako)

I didn't know this, but we are importing users from other database and they are used to look up for real names not nicknames. Of course, It was easy for me to customize your code to check user_login (display name) but then we have that problem with characters and spaces.
For now we tell them that there is no other option, we will see how they will get used to user names.

I don't know what is correct.

EDIT: there are fields: user_name, user_loginname, user_login. Sorry, I really can't remember which one is used where.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants