Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action to check if tests pass #9

Closed
3 tasks done
aruZeta opened this issue Aug 31, 2022 · 3 comments
Closed
3 tasks done

Add GitHub action to check if tests pass #9

aruZeta opened this issue Aug 31, 2022 · 3 comments
Labels
roadmap This ISSUE or PR is part of the roadmap of the project.

Comments

@aruZeta
Copy link
Owner

aruZeta commented Aug 31, 2022

  • Create a nimble task for running tests (don't like the default one)
  • Create the action
  • Doc generation workflow runs only when the tests have passed or when there was a push to main
aruZeta added a commit that referenced this issue Aug 31, 2022
aruZeta added a commit that referenced this issue Aug 31, 2022
Let's see how this fails ... (I hope not)

Issue: #9
@aruZeta
Copy link
Owner Author

aruZeta commented Aug 31, 2022

Also would be nice to make the doc generation workflow run only when the tests have passed or when there was a push to main.

Added as a task.

@aruZeta
Copy link
Owner Author

aruZeta commented Aug 31, 2022

Seems like it works, but it's not actually listed in the commit's run workflows:
Image

It would be nice that, when I create the README, I add badges for both workflows (even pages too).

@aruZeta
Copy link
Owner Author

aruZeta commented Aug 31, 2022

Also I actually only pushed the inputs of the flake to my cachix cache, so nim had to be built all over again and the action took around 8-10 minutes.

I have already pushed the actual outputs and now the actions seem to take around 2 mins!

So, since all the tasks have been completing, I'm closing this issue.

@aruZeta aruZeta closed this as completed Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap This ISSUE or PR is part of the roadmap of the project.
Projects
No open projects
Status: DONE
Development

No branches or pull requests

1 participant