Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not detect changes within namespaces #1

Closed
jerheff opened this issue Jan 6, 2014 · 2 comments
Closed

Does not detect changes within namespaces #1

jerheff opened this issue Jan 6, 2014 · 2 comments
Assignees
Labels

Comments

@jerheff
Copy link

jerheff commented Jan 6, 2014

Additions of new translation tokens within namespaces are not found via this task. For instance, this a valid translation table format:

{
  "NAMESPACE": {
    "SUB_NAMESPACE": {
       "TRANSLATION_ID1": "This is a namespaced translation."
    }
  }
}

In this case, the addition of TRANSLATION_ID2 would not be picked up by the task.

@arvidkahl
Copy link
Owner

Thanks for bringing this up, never knew there was the possibility of using namespaces. Man, my translation files will be much cleaner from now on. ♻️

@ghost ghost assigned arvidkahl Jan 6, 2014
@jerheff
Copy link
Author

jerheff commented Jan 6, 2014

Yeah, the namespaces are quite nice. Thanks for fixing this so quickly! It's a useful package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants