Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook dependency #255

Closed
djmannion opened this issue Jun 12, 2023 · 2 comments · Fixed by #259
Closed

notebook dependency #255

djmannion opened this issue Jun 12, 2023 · 2 comments · Fixed by #259

Comments

@djmannion
Copy link

(I'm a reviewer for the submission of preliz at JOSS)

This is in relation to the review criterion "Installation instructions: Is there a clearly-stated list of dependencies?".

Given the likely use of a jupyter notebook for the interactive aspects of the package, I'm wondering if notebook might be best listed as a dependency? Alternatively, perhaps it could be flagged in the "Installation" section of the docs that a pip install notebook may be required and again when plot_interactive is introduced.

@aloctavodia
Copy link
Contributor

Thanks for the feedback. @OriolAbril @aleicazatti which one of the options do you like best?

@OriolAbril
Copy link
Member

I would not make it a dependency. I think there are enough non interactive features, but specially because I think everything should work in either jupyter notebook or jupyter lab, depending on both doesn't make much sense, and depending on either pushes the choice to the users which is not good in my opinion.

What might be a good idea in addition to mentioning those in the docs, is extending the installation page, and defining a couple extra dependency bundles. Part of that could be similar to https://einstats.python.arviz.org/en/latest/installation.html and https://github.com/arviz-devs/xarray-einstats/blob/main/pyproject.toml#L46

@aleicazatti aleicazatti linked a pull request Jun 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants