Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When we click on the search button... #8

Closed
aryamangodara opened this issue Feb 12, 2022 · 3 comments · Fixed by #9
Closed

When we click on the search button... #8

aryamangodara opened this issue Feb 12, 2022 · 3 comments · Fixed by #9
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aryamangodara
Copy link
Owner

  • keyboard should automatically appear
  • search should be Realtime i.e. the letters we are writing should be simultaneously correspond to the list of games that will appear in screen body
  • when no game is found our users must see "No game found" in screen's body
  • after clicking the cross button keyboard should go back too
@aryamangodara aryamangodara added enhancement New feature or request good first issue Good for newcomers labels Feb 12, 2022
@aryamangodara
Copy link
Owner Author

@samitkapoor can you have a look 👀

@samitkapoor
Copy link
Contributor

@aryamangodara Yeah, sure ill take a look in my free time

@samitkapoor
Copy link
Contributor

@aryamangodara I have solved this issue and made a corresponding pull request.

@aryamangodara aryamangodara linked a pull request Feb 20, 2022 that will close this issue
Solved issue "When we click on search button..." #9
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solved issue "When we click on search button..." samitkapoor/Arcade-Plaza
2 participants
@samitkapoor @aryamangodara