Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

fenced code blocks still have "```" in the html #5

Closed
manukall opened this issue Sep 6, 2015 · 4 comments
Closed

fenced code blocks still have "```" in the html #5

manukall opened this issue Sep 6, 2015 · 4 comments
Assignees

Comments

@manukall
Copy link

manukall commented Sep 6, 2015

hi @asaaki,

Cmark.to_html("```\nTEST\n```")
=> "<pre><code>TEST\n```</code></pre>\n"

I think the "```" in the returned HTML shouldn't be there. If i run cmark from the command line with the same input I get

<pre><code>TEST
</code></pre>

which looks better.

I tried updating the c_src, but I didn't know how to get the .h files from the .h.in files in the cmark repo. I'm also not 100% sure it's a bug in the c code, as I checked out a version of cmark from may and that produced the correct HTML.

@asaaki asaaki self-assigned this Sep 6, 2015
@asaaki
Copy link
Owner

asaaki commented Sep 6, 2015

Hi @manukall,

Thank you for your feedback!

I've updated the C sources and it seems to work fine again.
I guess it is not really that unusual that some transformations are wonky or buggy since cmark and even the spec is still in development.

Try updating the dependency to 0.5.6 and tell me if it works for you, too.

@asaaki
Copy link
Owner

asaaki commented Sep 6, 2015

BTW If you want to update and test from sources locally you can always use the make target all-dev-test, which downloads and prepares the C sources properly.
This is what I do to get the latest changes from https://github.com/jgm/cmark.

@manukall
Copy link
Author

manukall commented Sep 6, 2015

yep, works. thanks a lot!
and thanks for the hint about all-dev-test, too. i was going to ask about that ;-)

@asaaki asaaki closed this as completed Sep 6, 2015
@asaaki
Copy link
Owner

asaaki commented Sep 6, 2015

You're welcome! 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants