Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng-click compatibility #9

Closed
cstephe opened this issue Jan 17, 2014 · 2 comments
Closed

ng-click compatibility #9

cstephe opened this issue Jan 17, 2014 · 2 comments

Comments

@cstephe
Copy link

cstephe commented Jan 17, 2014

I apologize if this is dumb. However, I'm using the directive as part of a dialog where the button to both export as csv and close the dialog is the same. on plunker ngcsv seems to ignore the ng-click. When used with angular bootstrap there are a bunch of errors. If there is a beforeExport and afterExport or some such I think that would help with compatibility.

RIght now I'm doing this.

  <div ng-csv="csvData" csv-header="colsToExport" filename="{{exportFileName}}">
    <button class="btn btn-primary" ng-click="ok()">OK</button>
  </div>

Where the div tightly wraps the button, because of event bubbling my ok method is preparing the csvData before the ngcsv sees the click basically giving me a beforeExport.

@asafdav
Copy link
Owner

asafdav commented Jan 17, 2014

Hi, No need for apologizes!
I just released a new version that supports ng-click (v0.0.6),
You can see the example in the repository or the unit tests.

I think it solves your issue, doesn't it ?

@asafdav asafdav closed this as completed Feb 24, 2014
@sumit89
Copy link

sumit89 commented May 3, 2016

Can u please provide the URL from where we can get this version (v0.0.6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants