Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD support for displaying current window tab count #5

Closed
allanlaal opened this issue Aug 26, 2017 · 2 comments
Closed

ADD support for displaying current window tab count #5

allanlaal opened this issue Aug 26, 2017 · 2 comments

Comments

@allanlaal
Copy link

discussed in #3 (comment)

@asafh
Copy link
Owner

asafh commented Aug 28, 2017

Unfortunately that's pretty awkward to do at the moment.
Firstly to know the number you have to keep track of which tab id belongs to which window id while they are updated (or as a workaround just query all tabs every time a tab is opened/closed/updated which isn't so nice of the extension).
Either solution, displaying that number will still be very inconvenient as chrome allows you to update the extension's browserAction (the button) either globally or for a specific tab, which means we'd still have to do tab-window ownership bookkeeping so we can set the information for it (either upon number change or when it becomes the selected tab in the window).

I'll keep it in mind but at least for now I'll hold on doing this - though you're welcome to open a PR.

@allanlaal
Copy link
Author

nah, this isn't as critical as an accurate global tab count

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants