Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple effect broken on iOS 13 + single-line bugfix #34

Open
michaelpeternell opened this issue Jul 5, 2020 · 0 comments
Open

Ripple effect broken on iOS 13 + single-line bugfix #34

michaelpeternell opened this issue Jul 5, 2020 · 0 comments

Comments

@michaelpeternell
Copy link

Hi,

great library. I have been looking for a library that shows touches because I need to make some promotional videos of an app of mine, and I chose this one because I liked the ripple effect. No other touch visualization library that I checked had that!

But I noticed that the ripple effect no longer works in iOS 13.5.1 (I suspect it doesn't work since iOS 13, but I haven't checked. It works in iOS 12.4.1)

The fix is easy. Just change line 114 of COSTouchVisualizerWindow.m from

[rippleView setFrame:CGRectInset(rippleView.frame, 25, 25)];

to

[rippleView setFrame:CGRectInset(rippleView.frame, 24, 24)];

It seems that iOS 13 doesn't like to animate the frame property to a zero-sized rectangle.

Is this library still maintained? The master branch is outdated and crashes, and the FixBugsAndUpdateAPI branch has not yet been merged into master. I'm currently using the FixBugsAndUpdateAPI branch together with the single-line change mentioned above.

All the best,
Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant