Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly acquired morphs not visible in Survival morph menu #37

Closed
SeaborneFright opened this issue Nov 13, 2020 · 12 comments
Closed

Newly acquired morphs not visible in Survival morph menu #37

SeaborneFright opened this issue Nov 13, 2020 · 12 comments
Assignees
Labels
bug Non-fatal error or unexpected behavior done Finished and / or Won't do

Comments

@SeaborneFright
Copy link

Hello!
I am using:
-Changeling 1.2.23 for 1.12.2
-DominionLib 2.1
-Forge 1.12.2-14.23.5.2847

Basically, despite acquiring morphs (they show up as acquired in the entity selector, i get the little "Acquired!" pop up, ect), they stop showing up in the survival morph menu after I've acquired a little number of them (around 18), rendering them effectively unusable without shifting to creative mode every time.

It is very possible that this is caused by me being stupid and I apologize in advance-
Thank and have a nice day!

@James103
Copy link

Is there a scroll bar that appears in the morph selection menu? If so, can you try scrolling down to see if more morphs appear?

@asanetargoss
Copy link
Owner

Thanks for submitting this bug report. There are no stupid questions. Changeling 1.2.3 was just released and is a big update incorporating a lot of upstream changes, including a new survival morph menu.

they stop showing up in the survival morph menu

Do you mean that all the morphs have vanished? If so, one possibility is that the "User Morphs" menu was toggled. Clicking it toggles the list of morphs between opening and closing, which could make the morphs not visible. Another possibility is that there's some sort of error when trying to render a modded morph... that might show up in the logs.

@SeaborneFright
Copy link
Author

Hi, thanks for answering so quickly!
So I tried things out on my own. To clarify, the previously acquired morphs still showed up, just not the new ones (vanilla and modded alike). There was no scroll bar. I also found that the issue is sometimes fixed by closing and reopening the game, though the issue seems to repeat after some time, or on new worlds, so it's not game-ending, it's just sort of annoying.
I'm not really good with anything regarding modding or even coding, so sorry if I can't be any more precise.

@asanetargoss
Copy link
Owner

Ah, in that case it sounds like the bug is that the scroll bar is not showing when it is supposed to.

@asanetargoss asanetargoss added the bug Non-fatal error or unexpected behavior label Nov 14, 2020
@Speecker
Copy link

Hey ;) I stumbled upon the same issue and did some specific testing wich got me the following result: It seems like changing your morph triggers the said issue that newly collected morphs wont be registered and shown in the selector GUI. To view them a World Reload (Going to Main Menu and reload said Save) is all it takes and as long as you do not demorph or change current moprh - any new will be registered as it should. Id say its a minor bug but i think its apreciatable if that inconvinence may be cleared out of the way.
For now bypass is to reload your Save/World to view new morphs if collected after a morph change.

@asanetargoss asanetargoss changed the title Can't acquire more morphs New morphs not visible in Survival morph GUI / Can't acquire more morphs Jan 2, 2021
@asanetargoss asanetargoss changed the title New morphs not visible in Survival morph GUI / Can't acquire more morphs Newly acquired morphs not visible in Survival morph menu Jan 2, 2021
@asanetargoss asanetargoss added this to the 1.2.3.hca.1 milestone Jan 2, 2021
@asanetargoss asanetargoss mentioned this issue Jan 2, 2021
2 tasks
@asanetargoss
Copy link
Owner

Hello, please try downloading the latest version of Changeling and DominionLib and see if they fix your issue.

@asanetargoss asanetargoss added the can't reproduce Won't do (bug does not exist / is described wrong) label Jan 18, 2021
@asanetargoss asanetargoss added info needed Won't do (unless more information given) and removed can't reproduce Won't do (bug does not exist / is described wrong) labels Feb 12, 2021
@asanetargoss
Copy link
Owner

asanetargoss commented Feb 12, 2021

@Speecker Do you think you can explain how you are able to reproduce this bug with the minimum mods required to reproduce it?

I have not been able to reproduce the bug as described with the information given so far.

@asanetargoss asanetargoss reopened this Feb 12, 2021
@Speecker
Copy link

Speecker commented Feb 12, 2021

@Speecker Do you think you can explain how you are able to reproduce this bug with the minimum mods required to reproduce it?

I have not been able to reproduce the bug as described with the information given so far.

Did some more testing and it seems like it is definitely fixed for Vanilla Mobs, but Modded Mobs dont work always.
For AOA3 (Advent of Ascension 3 / Nevermine) Mobs it seems to never work when you change your morph after loading the save-file. Tried it as well with backup-save-files and checked versions of the mods.
Cant say if it is especially AOA3 that is not working properly or other mods Mobs as well. Might have to test more to see a clear image wheather or not wich mobs won’t work correctly.

See Full ModList here: https://pastebin.com/FtaUYCzD

let me know if you need anything else like specific config.cfg or else

@asanetargoss
Copy link
Owner

@Speecker What might be helpful is if you start Minecraft, reproduce the bug, then send me your most recent logs. This may help narrow down the bug more.

@Speecker
Copy link

Speecker commented Feb 13, 2021

Caught it on Cam 🗡️

Bug Proof: https://streamable.com/swp2je

Workaround Proof: https://streamable.com/obpal2

It happened after changing Morph in Overworld, then going to the nether and slaying yet unacquired mobs and picking their morph up.
Im not sure but changning dimensions might be the trigger

@asanetargoss
Copy link
Owner

It happened after changing Morph in Overworld, then going to the nether and slaying yet unacquired mobs and picking their morph up.
Im not sure but changning dimensions might be the trigger

This is helpful, will see if I can reproduce this.

@asanetargoss asanetargoss removed the info needed Won't do (unless more information given) label Feb 13, 2021
@asanetargoss asanetargoss self-assigned this Feb 13, 2021
@asanetargoss asanetargoss mentioned this issue Feb 13, 2021
2 tasks
@asanetargoss
Copy link
Owner

I can indeed reproduce a morph GUI desync on 1.2.5.changeling.1. It seems to be triggered by either dying or switching dimensions... however only in survival. keepMorphs also needs to be false to reproduce, at least for the death case. Anyways, should be fixed in the new release.

@asanetargoss asanetargoss added the done Finished and / or Won't do label Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Non-fatal error or unexpected behavior done Finished and / or Won't do
Projects
None yet
Development

No branches or pull requests

4 participants