Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry refactor to resolve naming conflicts #61

Closed
nmatthews-asapp opened this issue Aug 29, 2019 · 1 comment
Closed

Registry refactor to resolve naming conflicts #61

nmatthews-asapp opened this issue Aug 29, 2019 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@nmatthews-asapp
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently registering multiple classes of the same name with YAML will not work properly. We should allow multiple distinct classes of the same name to be registered in different namespaces, e.g. "NLLLoss" and "torch.NLLLoss"

Describe the solution you'd like
The registry should be a separate entity (we should not rely on ruamel.yaml to maintain the registry) so that we can easily manage these cases. The registry will be implemented to organize namespaces as a mapping for tags and classes. Whenever ruamel.yaml is needed, the registry can be synced with yaml to ensure it's up to date.

@nmatthews-asapp nmatthews-asapp added bug Something isn't working enhancement New feature or request labels Aug 29, 2019
@nmatthews-asapp nmatthews-asapp self-assigned this Aug 29, 2019
@nmatthews-asapp
Copy link
Contributor Author

Fixed in v0.5 (refactor branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant