Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race conditions in async transactional handlers #21

Closed
mklimuk opened this issue Mar 15, 2017 · 0 comments
Closed

Race conditions in async transactional handlers #21

mklimuk opened this issue Mar 15, 2017 · 0 comments

Comments

@mklimuk
Copy link

mklimuk commented Mar 15, 2017

I detected race conditions in SubscribeAsync with transactional flag. It is due to the fact that we lock the handler after and not before spawning the async handler goroutine. On a fast machine it causes unpredictable behavior. Preparing a PR.

@bennAH bennAH closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants