New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change: required
no longer validates zero value strings
#359
Comments
I just spent some time trying out different commit SHAs, and it appears that this commit is what introduced this breakage: 2abf7b9 The switch from cc @asaskevich |
@bmhatfield Thank you, investigating for the solution |
I am also hitting this, is there any update? |
Any news regarding this issue? |
@asaskevich Anything new? This is clearly a breaking change. It prevents me from updating govalidator to a newer version since it breaks my application validation logic. |
Bump? Based upon the responses here, it seems like the breaking commit author's understanding is incomplete and perhaps 329 should be reverted? In particular, assuming that everyone can use pointers or must otherwise switch to the runelength validator seems incorrect to me. |
I'm facing this problem too! As a temporary workaround I had to change my code to also validate length which is by far not a great solution. Can we get some traction on this? Also having proper versions tagged and usable with go modules would help heaps in cases like this where we need to find a previous working version =( . See: #384 |
It appears this issue may have been resolved: 63eac46 |
Hello guys! |
I have a simple struct, like:
and a test like
On SHA
f61b66f89f4a
, this works as expected (the empty string values result in the test failing)On SHA
475eaeb16496
, it fails silently (the test passes without the expected error)This seems like a pretty significant regression / change, as validation that I expect to be performed is no longer being performed.
The text was updated successfully, but these errors were encountered: