Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new release to make sure it's in sync with the latest code #33

Open
atoonk opened this issue Feb 24, 2024 · 1 comment
Open

Comments

@atoonk
Copy link

atoonk commented Feb 24, 2024

Just a heads-up:
A while back (2,5 years), GetDescs(n int) was changed to GetDescs(n int, rx bool).
It looks like the release was never updated to include this change, so the latest release still uses the old way GetDescs(n int)
I'm assuming this is the recommended way.
Also, as a result, folks copying the example from the repo will see an error.

@atoonk
Copy link
Author

atoonk commented Feb 26, 2024

Just in case someone else has the same problem when following the example

# command-line-arguments
./sendudp.go:101:39: too many arguments in call to xsk.GetDescs
        have (number, bool)
        want (int)
./sendudp.go:130:47: too many arguments in call to xsk.GetDescs
        have (int, bool)
        want (int)

You can add the following to your go.mod , which will make sure you use a more recent version with the fix:
github.com/asavie/xdp v0.3.4-0.20220212172814-56d71236a029
example:
https://github.com/atoonk/go-pktgen/blob/main/go.mod#L6

Btw, this is not a problem if you clone the repo, in that case you have the latest code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant