Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete algorithms in Modern/OPL modes #242

Open
mkruselj opened this issue Oct 13, 2020 · 2 comments
Open

Incomplete algorithms in Modern/OPL modes #242

mkruselj opened this issue Oct 13, 2020 · 2 comments
Labels
enhancement

Comments

@mkruselj
Copy link
Contributor

https://github.com/asb2m10/dexed/blob/master/Source/msfa/fm_core.cc#L113

Algorithm 6 sounds exactly like algorithm 5 in modern/OPL mode because it doesn't calculate more than one operator in the feedback loop. Algorithm 4 is completely wrong too (3 operators in feedback loop). Mark I mode works because it has special case functions to calculate these (2 ops fb, 3 ops fb).

Bug report from here: https://www.kvraudio.com/forum/viewtopic.php?p=7847236#p7847236
@asb2m10
Copy link
Owner

asb2m10 commented Feb 19, 2021

Originally I was about to drop modern and OPL engine, thats why I didn't implement them. Since I kept those, I will put it on the TODO list.

@mkruselj
Copy link
Contributor Author

mkruselj commented Mar 6, 2021

Great news, thanks! 🙂

@DBraun DBraun mentioned this issue Nov 6, 2023
Open
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkruselj @asb2m10