Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: enabled prop for Droppable #13

Closed
azz0r opened this issue Dec 29, 2016 · 6 comments
Closed

Request: enabled prop for Droppable #13

azz0r opened this issue Dec 29, 2016 · 6 comments

Comments

@azz0r
Copy link

azz0r commented Dec 29, 2016

Draggable has enabled but Droppable does not.

Would be quite a minor change with a big pay off :)

@asbjornenge
Copy link
Owner

Taking a stab at this one. Should enabled={false} disable onDrag* too? Or only onDrop ?

I'll try to build out a better test spec too. Enzyme helps!

//cc @azz0r

@azz0r
Copy link
Author

azz0r commented Jan 4, 2017

Good question, I think both as you'd essentially be locking it but perhaps it could be granular?

@asbjornenge
Copy link
Owner

@azz0r Let's just disable them all for now, and see if we get issues. I have it implemented here - care to take a look at the diff? I even have tests 😄

//cc @educastellano

@azz0r
Copy link
Author

azz0r commented Jan 9, 2017

Sorry for the delay responding, I think it looks great!

@educastellano
Copy link
Collaborator

@asbjornenge it looks good to me, good job with the tests 🎉

@asbjornenge
Copy link
Owner

Out @ 2.3.0 🎉 Sorry it took forever 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants