Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix strategy of AsciiDocAPI Search for the asciidoc command file: #53

Merged
merged 2 commits into from
Nov 24, 2019

Conversation

jujumo
Copy link
Contributor

@jujumo jujumo commented Dec 9, 2018

also search for sibling files before for system wide path.

also search for sibling files before for system wide path.
@elextr
Copy link
Contributor

elextr commented Dec 9, 2018

Havn't tested but looks ok to me, @MasterOdin any comments?

@jujumo whilst I normally like a good argument about coding styles and especially something as contentious as "else considered harmful" for this just keeping the same style as the rest of the project is more important. Thanks for your understanding. BTW don't make a new PR for each change, just push correcting commits, we can squash them on merge.

If its suggested that the whole project style is to be changed then a separate issue just addressing that should be raised so that it can be discussed first, and (if its decided to go ahead) a suitable implementation strategy formulated (probably for progressive small changes).

@jujumo
Copy link
Contributor Author

jujumo commented Dec 9, 2018

Thanks for your review and your patience. that is my first PR. Next time, I'll manage to make correcting commits.

asciidocapi.py Outdated Show resolved Hide resolved
@elextr elextr added the waiting for input waiting for reply to review, updated code or similar label Apr 20, 2019
asciidocapi.py Outdated Show resolved Hide resolved
Copy link
Contributor

@aerostitch aerostitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put 2 suggestions based on @MasterOdin's comment but it looks good to me.

asciidocapi.py Outdated Show resolved Hide resolved
@MasterOdin MasterOdin merged commit 7a28945 into asciidoc-py:master Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for input waiting for reply to review, updated code or similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants