Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement converter for video and audio blocks #9

Closed
jxxcarlson opened this issue Aug 13, 2014 · 7 comments
Closed

Implement converter for video and audio blocks #9

jxxcarlson opened this issue Aug 13, 2014 · 7 comments

Comments

@jxxcarlson
Copy link

Here is one of the lines that didn't render properly in epub3:

.Video: random walk
video::random2a.m4v[width=400, align=center]

This is from 01.ad in the processing-book repo. The video does render properly with asciidoctor 1.5. I used iBooks as the epub3 reader. Everything (text, images) looked OK with except the video.

@mojavelinux
Copy link
Member

That's probably because we never implemented the video handler for EPUB3 as it wasn't required at the time we were creating the backend...so you're not missing anything...just the converter is :)

@mojavelinux mojavelinux changed the title video does not display implement converter for video and audio blocks Aug 13, 2014
@mojavelinux mojavelinux changed the title implement converter for video and audio blocks Implement converter for video and audio blocks Aug 13, 2014
@mojavelinux
Copy link
Member

I updated the issue title and added audio blocks since I know they aren't implemented either.

@mojavelinux mojavelinux added this to the v1.0.0 milestone Aug 13, 2014
@jxxcarlson
Copy link
Author

Thx!!

The new release is truly awesome. I love the level shifting.

On Aug 13, 2014, at 5:15 PM, Dan Allen notifications@github.com wrote:

I updated the issue title and added audio blocks since I know they aren't implemented either.


Reply to this email directly or view it on GitHub.

@mojavelinux
Copy link
Member

\o/

@edusantana
Copy link

This page provide the video tag for epub3 that can be tested with Android and Google play books:

https://support.google.com/books/partner/answer/3316879

@mojavelinux
Copy link
Member

I'm happy to report that Gitden now supports audio and video, so I finally have an e-book reader to test it on. We can do this now!

@slonopotamus
Copy link
Contributor

slonopotamus commented Feb 19, 2020

WRT video: Calibre only supports WEBM. Google Books claims to support WEBM + MP4 (H264). I would not be surprised if there are readers that only support MP4.

However, Asciidoctor video macro only allows to specify one file. We possibly need to do some trickery and look if there are files with different formats lying next to specified file and grab them also. I don't think we want to transcode on-the-fly during packaging.

slonopotamus referenced this issue in slonopotamus/asciidoctor-epub3 Mar 11, 2020
slonopotamus referenced this issue in slonopotamus/asciidoctor-epub3 Mar 11, 2020
slonopotamus referenced this issue in slonopotamus/asciidoctor-epub3 Mar 11, 2020
@slonopotamus slonopotamus added this to the v1.5.0.alpha.16 milestone Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants