Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plantuml !include not working #175

Closed
abelsromero opened this issue Apr 13, 2017 · 2 comments
Closed

plantuml !include not working #175

abelsromero opened this issue Apr 13, 2017 · 2 comments
Milestone

Comments

@abelsromero
Copy link
Member

abelsromero commented Apr 13, 2017

AsciiDoc Plugin Version:
0.17.3

IDE Name and Version:
IntelliJ IDEA 2016.3.6
Build #IU-163.15188.11, built on March 24, 2017
JRE: 1.8.0_111-b14 amd64
JVM: Java HotSpot(TM) 64-Bit Server VM by Oracle Corporation

Issue description
When I use the plantuml !include directive in a diagram block, the diagram-preview fails and shows the following text.

image

Expected behaviour
Should display the diagram correctly as if the contents of the included file were on the same plantum block.

Severity (at least for me)
Minor

Notes
I confirmed using the maven plugin, that the issue comes from the Asciidoctorj-diagram contained (version 1.5.0), with last version (1.5.4) this is fixed.
However, I am not sure this is enough, the includes are resolved relative to the AsciiDoc document. Unless this is taken into consideration, it won't work property.
Also, the plugin uses Asciidoctorj 1.5.4.1, last is 1.5.5. Does it make sense to you for a new release?

@ahus1
Copy link
Contributor

ahus1 commented Apr 15, 2017

@abelsromero - there is a preview version 0.18.0 of the plugin available from the github releases page.

This includes already the versions asciidoctorj-diagram 1.5.4 and Asciidoctorj 1.5.5.

A small include example worked for me. Please give it a try. If it doesn't work, please post a small source code snippet that shows what doesn't work for you.

@abelsromero
Copy link
Member Author

Works perfectly for me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants