Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider DirectoryScanner as alternative to copy resources using maven-filtering #335

Closed
abelsromero opened this issue Jan 20, 2018 · 2 comments · Fixed by #597
Closed

Comments

@abelsromero
Copy link
Member

abelsromero commented Jan 20, 2018

I stumbled upon org.codehaus.plexus.util.DirectoryScanner (plexus-utils) which offers a way to select files using include and exclude patterns.
This will require some extra boilerplate code but will provide this advantages:

  • Removing the use of org.apache.maven.model.Resource. Preventing confusion about the not-supported maven filtering options that now appear on some IDEs that offer maven's XML auto-completion.
  • Improve build time since the logic will be simplified.
  • Reduce the project dependencies since maven-filtering won't be necessary. That way users will have less to download.
@abelsromero abelsromero added this to the 2.2.0 milestone Oct 11, 2020
@abelsromero abelsromero modified the milestone: 2.2.0 May 7, 2021
@abelsromero
Copy link
Member Author

Even when filtering is not a supported feature, this can break build. So I am thinking that if we do this one, we should release as major 3.0.0.

@abelsromero
Copy link
Member Author

There seems to be an issue with latest maven 3.8.5 that would be mitigated with this change (https://issues.apache.org/jira/browse/MNG-7455?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17521077#comment-17521077).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant