Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply data-state 'title' to the title slide #123

Merged
merged 2 commits into from
Feb 10, 2017

Conversation

nipafx
Copy link
Contributor

@nipafx nipafx commented Feb 10, 2017

Some fancy stuff mind end up outside of slide sections and to give it special treatment on the title slide, the section's CSS class title does not suffice. (See a use case here, where the footer only shows from the second slide forward.)

This change applies the data-state title to the title slide, making reveal.js apply it as a CSS class to the document when the title slide is active.

The footer is outside the actual title slide so the slide's CSS class can not
be used to hide the footer. Instead a data state needs to be applied, which in
turn gets applied as a CSS class to the entire document by reveal.js.
@obilodeau
Copy link
Member

Looks good. The slides too!

Is the source / [S]CSS available somewhere? I would like to see how you've done footnotes so I can document it in our README.

I'll manually test your PR and merge.

@obilodeau
Copy link
Member

Works as advertised and found your repo. I'll try to submit a proposal for footers in asciidoctor-reveal.js based on your stuff I think.

@obilodeau obilodeau merged commit c60a1c9 into asciidoctor:master Feb 10, 2017
@nipafx
Copy link
Contributor Author

nipafx commented Feb 10, 2017

Oh, sorry for not reacting, was afk. Good thing, you found the repo.

I'll try to submit a proposal for footers in asciidoctor-reveal.js based on your stuff I think.

That would be awesome! 😃 Note that I use almost (but not quite) the same content on the title slide. Maybe you could provide a nice way to reuse the same content there.

@obilodeau
Copy link
Member

Note that I use almost (but not quite) the same content on the title slide. Maybe you could provide a nice way to reuse the same content there.

Covering all cases is not going to be easy. I invite you to subscribe to notifications in #53 and evaluate what we come up with.

@nipafx nipafx deleted the title-data-state branch July 22, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants