Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Asciidoctor.js 1.5.6+ #130

Closed
ggrossetie opened this issue Aug 15, 2017 · 4 comments
Closed

Upgrade to Asciidoctor.js 1.5.6+ #130

ggrossetie opened this issue Aug 15, 2017 · 4 comments
Milestone
1.1.0

Comments

@ggrossetie
Copy link
Member

Latest release: https://github.com/asciidoctor/asciidoctor.js/releases/tag/v1.5.6-preview.3

This release contains a lot of enhancements on the public API that should improve readability the Jade templates.

For instance:

-if node['$has_role?']('aside') || node['$has_role?']('speaker')
+if node.hasRole('aside') || node.hasRole('speaker')
@obilodeau
Copy link
Member

Besides updating the README setup instructions, is there something else that needs to be done to "resolve" this?

@obilodeau obilodeau added this to the 1.1.0 milestone Sep 26, 2017
@obilodeau
Copy link
Member

This will be achieved within 1.1.0 release.

@obilodeau
Copy link
Member

Some progress made, follow #143.

@ggrossetie ggrossetie mentioned this issue Oct 8, 2017
Merged
@obilodeau
Copy link
Member

Done with the #156 merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@ggrossetie @obilodeau