Converting the examples using javascript / node toolchain #149
Conversation
npm/builder.js
Outdated
| callback => builder.compileExamples(callback), // Compile examples | ||
| ], () => { | ||
| log.info(` | ||
| In order to visualize the result, a local HTTP server must be started within the root of this project otherwise you will have cross-origin issues. |
There was a problem hiding this comment.
I don't think it applies in this context
npm/builder.js
Outdated
| }); | ||
| }; | ||
|
|
||
| Builder.prototype.compileExamples = function (callback) { |
There was a problem hiding this comment.
I think the naming is misleading since we are not really compiling examples
There was a problem hiding this comment.
Fixed. Changed to convert.
| const builder = new Builder(); | ||
|
|
||
| log.task('examples'); | ||
| builder.examples(); |
There was a problem hiding this comment.
As mentioned in #156 (comment) I think we should use an "examples" task to demonstrate how to use the converter in JavaScript.
In the Asciidoctor.js repository, I have one example with a textarea on the left of the page and the rendered Reveal.js presentation on the right of the page.
There was a problem hiding this comment.
Not sure I understand what you mean. We have it in the documentation already. Adding an example would mean maintaining two copies of the same code and instructions.
There was a problem hiding this comment.
Alright, I thought the purpose of the examples task was to provide a "live" example.
| @@ -48,7 +50,7 @@ Builder.prototype.removeBuildDirSync = function () { | |||
| Builder.prototype.compile = function (callback) { | |||
| log.task('compile'); | |||
| var opalCompiler = new OpalCompiler({dynamicRequireLevel: 'ignore'}); | |||
| opalCompiler.compile('asciidoctor-revealjs', 'build/asciidoctor-revealjs.js', ['lib']); | |||
| opalCompiler.compile('asciidoctor-revealjs', 'build/asciidoctor-reveal.js', ['lib']); | |||
There was a problem hiding this comment.
You are probably right the revealjs.js is a bit too much 😉
obilodeau
force-pushed
the
npm-smoke-testing
branch
from
3709920
to
32d271f
Compare
obilodeau
changed the title
|
🎉 🎉 🎉 |
Just a start of javascript testing. People with javascript and npm experience please comment. I borrowed this from Asciidoctor.js and Asciidoctor-template.js.
Tests fail exactly where it should. Waiting on #143 to be fixed.