Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Reveal.JS 3.5.0 #151

Closed
3 tasks done
obilodeau opened this issue Sep 28, 2017 · 4 comments
Closed
3 tasks done

Upgrade to Reveal.JS 3.5.0 #151

obilodeau opened this issue Sep 28, 2017 · 4 comments
Labels
🍩 improvement
Milestone
1.1.0

Comments

@obilodeau
Copy link
Member

obilodeau commented Sep 28, 2017 •
edited

  • test how much breakage happens with forked themes
  • specify it in package.json
  • specify it in the install ruby docs
@obilodeau obilodeau added this to the 1.1.0 milestone Sep 28, 2017
@ggrossetie ggrossetie mentioned this issue Oct 2, 2017
Merged
@obilodeau
Copy link
Member Author

I have a problem with the speaker notes view right now with 3.5.0 more investigation is needed.

Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.

Seems related to hakimel/reveal.js#1883. However, they say it's fixed over there. Will try with an http server and report back.

@obilodeau
Copy link
Member Author

Confirmed: speaker notes now need an HTTP server to work

@obilodeau
Copy link
Member Author

Much of this porting work is happening in #146 now. I just tested custom themes I had and they still work.

@obilodeau
Copy link
Member Author

Fixed by the #146 merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍩 improvement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@obilodeau