More debugging docs #153
Merged
More debugging docs #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fails on Jruby 😞, I might only document it and not make it a dev dep |
jirutka
reviewed
Oct 5, 2017
HACKING.adoc
Outdated
| triggering statements and use the templates directly instead of debugging | ||
| compiled templates. You can call the slim templates directly with: | ||
|
|
||
| bundle exec asciidoctor --trace -T templates/ examples/customcss.adoc |
There was a problem hiding this comment.
You must also load slim-htag (-r slim-htag).
There was a problem hiding this comment.
I can't tell you what's going on but it's not necessary. With or without -r slim-htag it will yield the same files:
$ bundle exec asciidoctor --trace -T templates/ examples/customcss.adoc
$ sha1sum examples/customcss.html
6caf3d92da489f44919cefd8d9b803d2aeee559a examples/customcss.html
$ bundle exec asciidoctor --trace -T templates/ -r slim-htag examples/customcss.adoc
$ sha1sum examples/customcss.html
6caf3d92da489f44919cefd8d9b803d2aeee559a examples/customcss.html
To make sure I'm not doing anything wrong, I made further tests:
# calling asciidoctor-revealjs straight (after a fresh rake build)
$ bundle exec asciidoctor-revealjs examples/customcss.adoc
$ sha1sum examples/customcss.html
6caf3d92da489f44919cefd8d9b803d2aeee559a examples/customcss.html
# modifying templates
$ echo -e "p\n | Intruder alert" >> templates/document.html.slim
# running without -r slim-htag
$ bundle exec asciidoctor --trace -T templates/ examples/customcss.adoc
$ sha1sum examples/customcss.html
fdcceb5a1bf892713f9cec52b7902249eaff65d5 examples/customcss.html
# ^ output changed
# w/o a rake build, still get same file as before
$ bundle exec asciidoctor-revealjs examples/customcss.adoc
$ sha1sum examples/customcss.html
6caf3d92da489f44919cefd8d9b803d2aeee559a examples/customcss.html
So I would assess that the -r slim-htag is not necessary. At least in my environment.
|
Well, who would hack/debug with JRuby anyway (with insanely slow cold start)? |
jirutka
reviewed
Oct 5, 2017
asciidoctor-revealjs.gemspec
Outdated
| @@ -30,6 +30,7 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency 'rake', '~> 10.4.2' | |||
| s.add_development_dependency 'asciidoctor-doctest', '= 2.0.0.beta.4' | |||
| s.add_development_dependency 'pry', '~> 0.10.4' | |||
| s.add_development_dependency 'pry-byebug' | |||
There was a problem hiding this comment.
You can conditionally include it only for non-jruby engine.
|
Gave this one some love tonight. Feel free to take another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the rubyists a chance to comment