Fixed the display of include:: links for github and a broken link

[obilodeau]

Broken link found while reviewing #169, a 1.1.0 regression.

@mojavelinux I would like your opinion on the way I workaround GitHub's include:: are turned into link: behavior.

[mojavelinux]

What I recommend is just making a regular link when the GitHub environment is detected. No need to use an include since it won't get interpreted anyway.

ifeval::[{safe-mode-level} >= 20]
See <<examples/basic-example.adoc#,basic-example.adoc>>.
endif::[]
ifeval::[{safe-mode-level} < 20]
.basic-example.adoc
[source,asciidoc]
....
include::examples/basic-example.adoc[]
....
endif::[]

Technically it's better to check the safe mode level since that's what determines whether includes are enabled or not.

[obilodeau]

I made the suggested changes.

One thing though, a link to an adoc file on GitHub will display its converted version not the source. I think this could be confusing to users. We could link to a /raw/ link (example) but then the HTML version would no longer work offline as the link would no longer be relative.

Thoughts?

Edit: Worse than that, we would need to point to a specific branch or tag otherwise links could be broken if we ever move things around.

[obilodeau]

I created #176 to have that discussion since it is not release-critical and we need to do a release $soon.

[mojavelinux]

👍