Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #188, upgrade to Asciidoctor.js 1.5.6-rc.1 #189

Merged

Conversation

ggrossetie
Copy link
Member

@ggrossetie ggrossetie commented Mar 25, 2018

  • Remove bestikk-opal-compiler dependency (we now use opal-compiler directly)
  • Remove async dependency (not used anymore)
  • Simplify build scripts and use ECMAScript 6 syntax
  • Run the task examples on Travis
  • The examples task does not run the task build anymore

* Remove 'bestikk-opal-compiler' dependency (we now use 'opal-compiler' directly)
* Remove async dependency (not used anymore)
* Simplify build scripts and use ECMAScript 6 syntax
* Run the task examples on Travis
* The examples task does not run the task build anymore
@obilodeau obilodeau merged commit a0e6386 into asciidoctor:master Jun 23, 2018
@obilodeau
Copy link
Member

One thing I'm wondering. We are providing a package-lock.json now? How and when should this be maintained?

@ggrossetie
Copy link
Member Author

package-lock.json is generated by npm install and it should be commited when you upgrade, add or remove a dependency.

Basically when you edit package.json (or run npm install pkg), you should run npm install and commit both package.json and package-lock.json: https://docs.npmjs.com/files/package-lock.json

We should also probably require Node.js 6+ or 8+:

"node": ">=4",

I believe that package-lock.json was introduced in npm 5+ (available in Node 6+).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants