Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated JavaScript toolchain components to be able to build master #217

Closed
wants to merge 1 commit into from

Conversation

obilodeau
Copy link
Member

Didn't want to go with latest. Went with closest version to make it work.

@obilodeau obilodeau added this to the 1.2.0 milestone Nov 2, 2018
@obilodeau
Copy link
Member Author

What I don't understand is why is Travis running npm run build fine when I needed to update because locally it failed with this:

$ npm run build

> asciidoctor-reveal.js@1.1.4-dev build /home/olivier/src/asciidoc/asciidoctor-reveal.js
> node npm/build.js

Object freezing is not supported by Opal
Object tainting is not supported by Opal

clean
 - remove build directory

compile
/home/olivier/src/asciidoc/asciidoctor-reveal.js/npm/compiler.js:8
  const opalBuilder = OpalBuilder.create();
                                  ^

TypeError: OpalBuilder.create is not a function
    at Object.module.exports.compile (/home/olivier/src/asciidoc/asciidoctor-reveal.js/npm/compiler.js:8:35)
    at compile (/home/olivier/src/asciidoc/asciidoctor-reveal.js/npm/build.js:17:18)
    at Object.<anonymous> (/home/olivier/src/asciidoc/asciidoctor-reveal.js/npm/build.js:38:1)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:279:19)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! asciidoctor-reveal.js@1.1.4-dev build: `node npm/build.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the asciidoctor-reveal.js@1.1.4-dev build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/olivier/.npm/_logs/2018-11-02T01_30_22_194Z-debug.log

@obilodeau
Copy link
Member Author

Failing tests are unrelated and due to #216

@obilodeau
Copy link
Member Author

This PR is obsoleted by #219 which contained the fix and was merged.

@obilodeau obilodeau closed this Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant