Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Embed in babel-using Javascript frameworks #218

Closed

Conversation

obilodeau
Copy link
Member

Running smoke tests with the ruby build (instead of the previous javascript one) fails with:

$ node test/smoke.js 

/home/olivier/src/asciidoc/asciidoctor-reveal.js/node_modules/asciidoctor.js/dist/node/asciidoctor.js:16545
          } else { throw $err; }
                   ^
NotImplementedError: asciidoctor: FAILED: missing converter for backend 'revealjs'. Processing aborted.
    at Opal.send (/home/olivier/src/asciidoc/asciidoctor-reveal.js/node_modules/opal-runtime/src/opal.js:1610:19)
    at singleton_class_alloc.$$exception [as $exception] (/home/olivier/src/asciidoc/asciidoctor-reveal.js/node_modules/opal-runtime/src/opal.js:5344:14)
    at $Document.$$raise [as $raise] (/home/olivier/src/asciidoc/asciidoctor-reveal.js/node_modules/opal-runtime/src/opal.js:5037:31)
    at $Document.$$update_backend_attributes [as $update_backend_attributes] (/home/olivier/src/asciidoc/asciidoctor-reveal.js/node_modules/asciidoctor.js/dist/node/asciidoctor.js:6557:18)
    at $Document.$$initialize [as $initialize] (/home/olivier/src/asciidoc/asciidoctor-reveal.js/node_modules/asciidoctor.js/dist/node/asciidoctor.js:5874:16)
    at Object.Opal.send (/home/olivier/src/asciidoc/asciidoctor-reveal.js/node_modules/opal-runtime/src/opal.js:1610:19)
    at singleton_class_alloc.TMP_Class_new_5 [as $new] (/home/olivier/src/asciidoc/asciidoctor-reveal.js/node_modules/opal-runtime/src/opal.js:3501:12)
    at /home/olivier/src/asciidoc/asciidoctor-reveal.js/node_modules/asciidoctor.js/dist/node/asciidoctor.js:16511:45
    at module_constructor.$$load [as $load] (/home/olivier/src/asciidoc/asciidoctor-reveal.js/node_modules/asciidoctor.js/dist/node/asciidoctor.js:16512:28)
    at module_constructor.$$convert [as $convert] (/home/olivier/src/asciidoc/asciidoctor-reveal.js/node_modules/asciidoctor.js/dist/node/asciidoctor.js:16629:20)

Please advise @Mogztter. I know you have probably preferred I kept the node toolchain but the PR you refered me too compiled with Ruby and it didn't know how to do it in JS.

Note that right now, I copy manually build/asciidoctor-reveal.js to dist/main.js before running node test/smoke.js.

Related to #205.

@obilodeau
Copy link
Member Author

Superseded by #219

@obilodeau obilodeau closed this Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants