Js embed modern frameworks #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically this commit: jirutka/asciidoctor-html5s@4702cb2 With tweaks by me.
ggrossetie
commented
Nov 2, 2018
ggrossetie
commented
Nov 2, 2018
ggrossetie
commented
Nov 2, 2018
- it simplified node dependencies - adjusted documentation - adjusted Travis build
|
All standard tests pass. Test failures are related to the This is ready for a merge. Letting @Mogztter having a look at it before I merge. TODO: this PR's changelog entry will need to highlight that this is an API breaking change regarding how to use |
obilodeau
approved these changes
Nov 3, 2018
Also allows us to retest in the future and not forget about that use-case.
obilodeau
approved these changes
Nov 4, 2018
ggrossetie
commented
Nov 4, 2018
ggrossetie
commented
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't push on your branch so I've created a new pull request based on your work with two fixes.
ping @obilodeau