Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish JAR #271

Closed
johnjelinek opened this issue Aug 27, 2019 · 15 comments · Fixed by #337
Closed

Publish JAR #271

johnjelinek opened this issue Aug 27, 2019 · 15 comments · Fixed by #337

Comments

@johnjelinek
Copy link

Could you please publish this gem as something that can be brought in on the JVM? Seems like this has been done for some other backends:

@obilodeau
Copy link
Member

I have no idea how to do this... Since this is volunteer work, I'm not interested in doing it either. I haven't written Java since University when gradle and maven didn't even exist (or were not popular). That said, if someone does the packaging and I only need to keep it current via simple updates, I'm willing to maintain it.

For the record, this is what happened with Asciidoctor.js support and Doctests. Someone else did it but I maintain it diligently. It can work. Are you willing to do the initial push?

@mojavelinux
Copy link
Member

Generally, the translation to an AsciidoctorJ JAR is handled by the AsciidoctorJ team. As more extensions get redistributed this way, the process of automating those builds improves so they require very little minimal maintenance. Ideally, the release would happen automatically.

That being said, it's possible to use a gem without the extra packaging. The following example demonstrates how: https://github.com/asciidoctor/asciidoctor-maven-examples/blob/master/asciidoc-to-revealjs-example/pom.xml So it's inaccurate to say it can't be used on the JVM now.

@mojavelinux
Copy link
Member

cc: @robertpanzer

@robertpanzer
Copy link
Member

I can take care of that.
I can’t give a timeline though, maybe I’ll get sth done over the holidays.

@mojavelinux
Copy link
Member

Cool! The converter is popular enough that I believe the effort would be worthwhile.

@obilodeau
Copy link
Member

Generally, the translation to an AsciidoctorJ JAR is handled by the AsciidoctorJ team.

Once the initial packaging process is done (the scary, unknown part for me), I'm willing to attempt to send PRs to AsciidoctorJ to update the JAR. Just like I do to update asciidoctor.org website right now anyways.

I'm going to close this with these last words: If you need this, open an issue on the AsciidoctorJ repo.

@robertpanzer
Copy link
Member

I already created a rep for that at robertpanzer/asciidoctorj-reveal.js. It’s just waiting for the transfer into the asciidoctor org

@mojavelinux
Copy link
Member

Oh, I can help with that! You should be able to transfer now. Give it a try.

@robertpanzer
Copy link
Member

Awesome, thanks. I’ll try it over the weekend

@robertpanzer
Copy link
Member

I created a release candidate that can be used like this:

      <plugin>
        <groupId>org.asciidoctor</groupId>
        <artifactId>asciidoctor-maven-plugin</artifactId>
        <version>2.0.0-RC.1</version>
        <configuration>
          <backend>revealjs</backend>
          <requires>
            <require>asciidoctor-revealjs</require>
          </requires>
          <attributes>
            <imagesdir>${project.build.directory}/generated-docs</imagesdir>
            <revealjsdir>https://cdnjs.cloudflare.com/ajax/libs/reveal.js/3.7.0</revealjsdir>
          </attributes>
        </configuration>
        <dependencies>
          <dependency>
            <groupId>org.asciidoctor</groupId>
            <artifactId>asciidoctorj</artifactId>
            <version>2.2.0</version>
          </dependency>
          <dependency>
            <groupId>org.asciidoctor</groupId>
            <artifactId>asciidoctorj-revealjs</artifactId>
            <version>3.1.0-rc.2</version>
          </dependency>
    <dependencies>
  </plugin>
...
    <profile>
      <repositories>
        <repository>
          <snapshots>
            <enabled>false</enabled>
          </snapshots>
          <id>bintray-asciidoctor-maven</id>
          <name>bintray</name>
          <url>https://dl.bintray.com/asciidoctor/maven</url>
        </repository>
      </repositories>
      <pluginRepositories>
        <pluginRepository>
          <snapshots>
            <enabled>false</enabled>
          </snapshots>
          <id>bintray-asciidoctor-maven</id>
          <name>bintray-plugins</name>
          <url>https://dl.bintray.com/asciidoctor/maven</url>
        </pluginRepository>
      </pluginRepositories>
      <id>bintray</id>
    </profile>

@obilodeau
Copy link
Member

Should we add a reference to the asciidoctor/asciidoctorj-reveal.js repo in our README as another installation option?

@obilodeau obilodeau reopened this Feb 10, 2020
@robertpanzer
Copy link
Member

Great idea!
Let's do this after I have released the first final version.

@robertpanzer
Copy link
Member

Asciidoctorj-revealjs is now available at jcenter and at https://search.maven.org/artifact/org.asciidoctor/asciidoctorj-revealjs/3.1.0/jar

@johnjelinek
Copy link
Author

I can't believe this day has finally come!

@obilodeau
Copy link
Member

Request for comments on the PR with README adjustments: #337

Last issue before 4.0.0 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants